search

microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
22.01k stars 6.12k forks source link

[boost-math] Fix build on x64-linux-dynamic, add feature legacy #38728

Closed Osyotr closed 2 weeks ago

Osyotr commented 1 month ago

Fixes #38725 Fixes #38714 Fixed https://github.com/microsoft/vcpkg/issues/38955

Neumann-A commented 4 weeks ago

there are two ports which require the boost legacy libs. See https://github.com/microsoft/vcpkg/pull/32309#discussion_r1579699905

Neumann-A commented 4 weeks ago

hmm you probably need to edit vcpkg-boost to have some internal variable to allow marking boost ports as header only if there is a source dir. Or alternative you simply delete "${SOURCE_PATH}/src" if the feature is not enabled (breaks --editable workflows but whatever).

Osyotr commented 4 weeks ago

@Neumann-A can I reuse features.cmake for that? I.e. add set(Z_VCPKG_BOOST_FORCE_HEADER_ONLY ON) to features.cmake and check for it in boost_configure_and_install.

Neumann-A commented 4 weeks ago

@Neumann-A can I reuse features.cmake for that?

Do as you like. You need to do an additional feature check anyway so putting it in that files seems kind of reasonable.

Osyotr commented 3 weeks ago

@vicroms there's no notification if you mark PR as draft, so please leave comment when you do so.