Open DadanielZ opened 4 weeks ago
Not sure, if it helps, but here is our overlay port of xgboost of version v2.0.3 xgboost.tar.gz
We are using it to build our application getML on Linux.
The x86 and arm64 logs seem to indicate problems with intrinsics IIUC. And uwp doesn't offer some of the windows API. Probably these triplets need to be excluded from supported
.
There is also a warning
cl : Command line warning D9025 : overriding '/MTd' with '/MDd'
@dg0yt Currently, XGBoost sets the MSVC link flags (/MT
or /MD
) by editing the raw build flags, an approach I feel is potentially problematic (https://github.com/dmlc/xgboost/issues/10344). Do you think fixing this would help with distributing XGBoost on vcpkg?
You just have to use the options it offers.
CMAKE_MSVC_RUNTIME_LIBRARY
isn't used by the vcpkg toolchain which controls flags directly and still supports older versions of CMake.
Got it. Would it be a problem for you if XGBoost would start using CMAKE_MSVC_RUNTIME_LIBRARY
flag and require CMake 3.15 some time in the future?
Got it. Would it be a problem for you if XGBoost would start using
CMAKE_MSVC_RUNTIME_LIBRARY
flag and require CMake 3.15 some time in the future?
Nothing which couldn't be solved. The key is that projects don't change flags which are meant do be set by the user or toolchain.
Add open-source library xgboost to vcpkg xgboost github repo: https://github.com/dmlc/xgboost/
find_package
calls are REQUIRED, are satisfied byvcpkg.json
's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx.vcpkg.json
matches what upstream says.vcpkg.json
matches what upstream says../vcpkg x-add-version --all
and committing the result.