search

microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
22.89k stars 6.31k forks source link

[boost-dll] Make Spirit.X3 dependency conditional #39075

Closed ajtribick closed 3 months ago

ajtribick commented 3 months ago

Is your feature request related to a problem? Please describe.

Mangled import is described as "not throroughly tested and thus not considered stable". On Windows this feature is implemented using Spirit.X3, which has a reasonably large dependency tree. However the Spirit.X3 dependency is currently pulled in when installing boost-dll regardless of OS.

Proposed solution

Put mangled import support behind a port feature (I don't have a strong opinion here if the feature should be enabled by default), and only pull in Spirit.X3 if the feature is enabled on a Windows target.

Describe alternatives you've considered

No response

Additional context

No response

Osyotr commented 3 months ago

The dependency is unconditional. https://github.com/boostorg/dll/blob/6c60dde50bf67138c90cc84938111866813feaff/CMakeLists.txt#L25 If you believe this is wrong, please open an issue in the upstream repo.