search

microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
23.36k stars 6.46k forks source link

[flint] update to 3.1.3-p1 #39293

Open tueda opened 5 months ago

tueda commented 5 months ago

Library name

Flint

New version number

3.1.3-p1

Other information that may be useful (release notes, etc...)

https://github.com/flintlib/flint/releases/tag/v3.1.3-p1

MonicaLiu0311 commented 5 months ago

@fredrik-johansson @albinahlback Just want to confirm with you, what is the relationship between v3.1.3-p1 and v3.1.3? Does "p1" mean patch1?

albinahlback commented 5 months ago

I never updated the version number when pushing the new patches. For instance, v3.1.3 claims that it is version v3.1.0. @edgarcosta realized this and patched this with v3.1.3-p1.

MonicaLiu0311 commented 5 months ago

I never updated the version number when pushing the new patches. For instance, v3.1.3 claims that it is version v3.1.0. @edgarcosta realized this and patched this with v3.1.3-p1.

OK, thanks for your reply. So, does it mean that v3.1.3-p1 is the official release version of 3.1.3? Will the official release version after it be v3.1.4 or v3.1.3-p2/v3.1.4-p1?

albinahlback commented 5 months ago

OK, thanks for your reply. So, does it mean that v3.1.3-p1 is the official release version of 3.1.3? Will the official release version after it be v3.1.4 or v3.1.3-p2/v3.1.4-p1?

It should be v.3.1.4 or v3.2.0 (i.e. no "-pX" suffix).

MonicaLiu0311 commented 5 months ago

@tueda Can I update it to 3.1.2? If I update to 3.1.3-p1, the version field in vcpkg.json will change. 3.1.3-p1 must use the version-string field, and "version" and "version-string" cannot be compared. Moreover, 3.1.3-p1 is an accidental event and will not continue this version format in the future. We can update to 3.1.2 now, skip 3.1.3 and wait for the next official version directly.

tueda commented 5 months ago

@tueda Can I update it to 3.1.2?

I think this is sufficient for now, as the change from version 2.x to version 3.x seems more significant.