microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS
MIT License
23.03k stars 6.36k forks source link

[icu] [python3] list of dependencies for Red Hat needs updating #40670

Open sweemer opened 1 month ago

sweemer commented 1 month ago

Is your feature request related to a problem? Please describe.

The portfiles for both icu and python3 contain the following instructions for installing dependencies:

On recent Red Hat and Fedora derivatives:
    sudo dnf install autoconf automake autoconf-archive

Out of these, I can only find autoconf and automake in the package manager for RHEL 8.6 - it seems that autoconf-archive is not available.

I eventually figured out how to get the python3 port to build by downloading autoconf-archive from here, building and installing manually, and then moving the installed files from /usr/local/share/aclocal to /usr/share/aclocal where vcpkg can find them.

I'm not sure whether this process is something that should be documented in the portfile, but I unfortunately am not aware of any better solution. In any case, the instructions should be updated to avoid giving the impression that autoconf-archive is available from the Red Hat package manager when it is not.

Proposed solution

Perhaps the wording can be updated as follows:

On recent Red Hat and Fedora derivatives:
    sudo dnf install autoconf automake
    install autoconf-archive from https://gnu.mirror.constant.com/autoconf-archive/

Describe alternatives you've considered

No response

Additional context

No response

SchaichAlonso commented 1 day ago

The ports shouldn't emit a notice. We invoke code that requires autoconf-archive to be installed in vcpkg_configure_make, therefore, if we emit a diagnostic for RHEL, it should be vcpkg_configure_make that emits it, rather then the ports.

RHEL seems to actually be maintaining an autoconf-archive package in a supplementory repository ... but require users to pay them in order to get access to it 💯✍

Given the

install autoconf-archive from https://gnu.mirror.constant.com/autoconf-archive/

instruction is quite non-trivial, I suggest adding a Section for RHEL to the supported hosts document explaining the steps reqiuired to deploy a usable autoconf-archive onto RHEL systems, rathern then emiting a diagnostic.

dg0yt commented 21 hours ago

The ports shouldn't emit a notice. We invoke code that requires autoconf-archive to be installed in vcpkg_configure_make,

This is wrong. vcpkg provides autoconf-archive only for Windows where it takes all the tools from MSYS2.