Port request: libopenmpt

microsoft / vcpkg

C++ Library Manager for Windows, Linux, and MacOS

MIT License

23.24k stars 6.41k forks source link

Port request: libopenmpt #503

Closed debrouxl closed 6 years ago

debrouxl commented 7 years ago

libopenmpt is a newer derivative of the original modplug code than libmodplug, which is already in the vcpkg ports tree. libopenmpt offers better accuracy and better security than libmodplug does; it is more actively maintained. It's a better choice for the short term and the long term.

I'm not merely repeating what the official site https://lib.openmpt.org/libopenmpt/ states :-) Although libmodplug usually does the job, I've noticed that it audibly misrenders several recent modules by Saga Musix.

atkawa7 commented 6 years ago

@ras0219-msft can be closed now

debrouxl commented 6 years ago

Why ? AFAICS:

a case-insensitive grep of "openmpt" in the whole vcpkg repo at the current HEAD revision ( f0fea1d58801167778f9f77f91ecf08a8438e135 ) comes up empty;
libmodplug's security issues have only been partially fixed upstream;
libmodplug's rendering inaccuracies remain.

sagamusix commented 6 years ago

vcpkg support was being worked on but I wasn't aware that it's finished yet.

atkawa7 commented 6 years ago

@ras0219-msft my apologies I thought I had seen this somewhere

alexkaratarakis commented 6 years ago

Merged, thanks!

manxorist commented 6 years ago

I'm the libopenmpt maintainer. Apparently Github does not send email notifications about an issue being referenced by a pull request. (i.e. I was not notified about https://github.com/Microsoft/vcpkg/issues/503#ref-pullrequest-292196745 ). I thus only became aware of this pull request when it had already been merged and this issue got closed. Please see my comments on the changes: https://github.com/Microsoft/vcpkg/pull/2669