microsoft / vivainsights-py

Python package for Analyzing and Visualizing data from Viva Insights
https://microsoft.github.io/vivainsights-py/
Other
13 stars 2 forks source link

Pip install fails due to deprecated sklearn package #11

Closed cagrimunyas closed 1 year ago

cagrimunyas commented 1 year ago

Repro :

martinctc commented 1 year ago

Thanks @cagrimunyas - we'll have a look at this!

sachinstl commented 1 year ago

Hi @cagrimunyas ,

Kindly find link for scikit learn library / below screenshot for scikit learn library.

image

There are changes for sklearn to scikit-learn. I tried reproducing the similar issue you are facing. Python 10.80 version is giving an error with scikit-learn (we have to use sklearn instead of scikit-learn in python 10.80) but latest python version won't create any issue for scikit-learn.

Kindly update your python version and try installing the vivainsights.

Thanks

cagrimunyas commented 1 year ago

Thank you @sachinstl, I've already installed it using the github repo itself. Inside vivainsights repo the requirement is typed as "scikit-learn" rather than the deprecated "sklearn". That's not the case for the pip package Please check: https://github.com/microsoft/vivainsights-py/blob/main/requirements.txt

I have also tried installing it via pip with python 3.11.4, it raised the same error. Also the ss you shared says the opposite of what you wrote. Using "sklearn" instead of "scikit-learn" will raise error in any python versins as it's depreceated, unless there is an env variable stated it in the last resort item.

Also one of the commits acknowledges this https://github.com/microsoft/vivainsights-py/commit/beb59f7c28b4a9608530d09b989df6ebc03ee6fb. Simply pushing the latest version to the repo to the pip will resolve this.