search

microsoft / vivainsights-py

Python package for Analyzing and Visualizing data from Viva Insights
https://microsoft.github.io/vivainsights-py/
Other
14 stars 2 forks source link

Make `return_type` consistent for data validation functions #12

Closed martinctc closed 10 months ago

martinctc commented 10 months ago

Currently, identify_holidayweeks() and identify_inactiveweeks() take different input values in return_type() when returning the 'cleaned' dataset excluding the outliers: 

vi.identify_holidayweeks(vi.load_pq_data, sd = 1, return_type = "cleaned_data")

vi.identify_inactiveweeks(vi.load_pq_data, sd = 1, return_type = "data_cleaned")

Both options should be allowed in either functions in order to return a 'cleaned' dataset.