microsoft / vivainsights-py

Python package for Analyzing and Visualizing data from Viva Insights

https://microsoft.github.io/vivainsights-py/

Other

14 stars 2 forks source link

Patch: Improve test coverage and bug fixes to `network_p2p()` #21

Closed sachinstl closed 7 months ago

sachinstl commented 8 months ago

Summary

This pull request increments the package version to v0.2.3, fixes some bugs, and improves test coverage in the package.

Changes

The changes made in this PR are:

Changes in number of legend columns to handle the orientation of legends in the plot. handler_map added from matplotlib under legend code.
Added new examples to explore network_p2p functionalities.
New tests are added for the package.

Checks

[x] All checks pass (run python -m unittest discover -s tests -f locally)
[x] Versions are updated in pyproject.toml, setup.py, and docs/conf.py (if applicable)
[x] NEWS.md has been updated

Notes

This fixes #19, where the legend is not displaying proper in network_p2p() with certain key numbers.

martinctc commented 7 months ago

Thanks for your contributions @sachinstl! Merging this into main now.