microsoft / vivainsights

R library to analyze and visualize data from Viva Insights Analyst Experience
https://microsoft.github.io/vivainsights/
Other
10 stars 2 forks source link

Bugfix: `create_line()` assumes y-axis label is 'Weekly hours' #28

Closed martinctc closed 6 months ago

martinctc commented 6 months ago

Currently, the plot output of create_line() assumes that the vertical axis will represent 'Weekly hours', as it is explicitly stated in the code.

However, this is not necessarily the case, as this can be used to measure variables like internal network size.

A more appropriate value would be the metric value that is provided to the parameter of the function, ideally formatted with us_to_space() so that underscores are replaced with spaces.

https://github.com/microsoft/vivainsights/blob/5d65430d7c3335eeab1036993a56ce3605bdda50/R/create_line.R#L140