microsoft / vivainsights

R library to analyze and visualize data from Viva Insights Analyst Experience
https://microsoft.github.io/vivainsights/
Other
11 stars 2 forks source link

Minor bug fixes and release patch version `v0.5.3` #33

Closed sachinstl closed 4 months ago

sachinstl commented 5 months ago

Summary

This branch fixes issues #30, #31, #32, and prepares the patch version v0.5.3 for CRAN release.

Changes

The changes made in this PR are:

  1. Improvement: We can remove x-axis label in this special case, where hrvar is set to NULL. #30
  2. Improvement: Change the plot title according to the metric when metric has single value. #31
  3. Improvement: We can add input validation to ensure the data is a data frame, predictors are columns in the data, and outcome is a binary variable in the data. #32

Checks

Notes

This fixes #30, #31, #32.

Incorporated changes:

  1. After fix on bug 30
    create_boxplot(pq_data, metric = "Collaboration_hours", hrvar = NULL, return = "plot")
image
  1. After fix on bug 31

    pq_data %>% 
    create_stacked(hrvar = "FunctionType", 
                 metrics = "Meeting_hours", 
                 return = "plot" 
                 ) 
    image
  2. After fix on bug 32

    pq_data %>%
     create_stacked(hrvar = "FunctionType",
                    metrics = c("Meeting_hours"
                                ),
                    return = "plot",
                    plot_title = "Collaboration Hours",
                    rank = "ascending")
image
martinctc commented 5 months ago

Thank you for all the fixes @sachinstl, they all look fine! I have made a few additional changes to prepare the patch release of v0.5.3. I will merge this once I have confirmation that this is accepted into CRAN.

martinctc commented 4 months ago

v0.5.3 is now on CRAN - thank you for your contributions @sachinstl.