search

microsoft / vs-azure-iot-edge-docs

Documentation for Azure IoT Edge Tools for Visual Studio
Creative Commons Attribution 4.0 International
5 stars 6 forks source link

"Build IoT Edge Modules" does not use module.json buildOptions #31

Open vermillionsword opened 3 years ago

vermillionsword commented 3 years ago

Machine

In my module.json I am attempting to pass a build arg like so: "buildOptions": [ "--build-arg PAT=${PAT}" ] ($PAT coming from a .env file)

When I right-click on my iotedgeproj and hit "Build IoT Edge Modules", the docker build does not include my custom build options:

docker build --rm -f "C:\repos\EdgePlatform\CleanSpark.Edge\CleanSpark.Edge.FeedModule\Dockerfile.amd64.debug" -t localhost:5000/feedmodule:0.0.1-amd64.debug "C:\repos\EdgePlatform\CleanSpark.Edge\CleanSpark.Edge.FeedModule"

marianan commented 3 years ago

@vermillionsword thanks for reporting this issue, we will investigate and update this thread.

syedhassaanahmed commented 3 years ago

+1 We're facing exactly the same issue. VSCode takes module.json into account but it seems there is an experience downgrade in VS2019 which completely ignores the module.json file.

vermillionsword commented 3 years ago

@marianan Is there a timeframe on when this issue might be resolved?

marianan commented 3 years ago

@vermillionsword this issue is in our backlog; we don't have an ETA at this time. If this is a critical/blocking issue, please share why. Would using VSCode unblock the scenario until we get to investigate and resolve this issue? Are there other work arounds?

vermillionsword commented 3 years ago

@marianan VS Code will work for now. Thank you for the update.