search

microsoft / vs-ng-language-service

Visual Studio extension for the Angular Language Service
MIT License
43 stars 15 forks source link

Remove WebTools shim from 2022 extension #46

Closed MariaSolOs closed 1 year ago

MariaSolOs commented 1 year ago

This PR removes the WebTools synchronous shim from the 2022 extension and instead updates the Angular component content type to extend from the HTML LSP content type, allowing us to also provide completions inside {{ }}: Screenshot 2022-10-26 101255

This only affects the 2022 version of the extension, since in 2019 we get no completions at all without the WebTools shim.

PranavSenthilnathan commented 1 year ago

I remember you mentioned that HTML LSP was a preview feature. Does this work even without that? Also wondering if it works on 17.0?

MariaSolOs commented 1 year ago

@PranavSenthilnathan yeah this is the result with the HTML LSP editor disabled. If we enable it, the content type changes so in fact the extension is disabled in non-TS files in that case. However now that you mention it there's no reason not to add the content type to the client so that it also works with the HTML LSP editor enabled.

MariaSolOs commented 1 year ago

Sigh this doesn't work in 17.0... :(

Fixed now!