microsoft / vs-servicehub

The service broker libraries used by Visual Studio to exchange intra- and inter-process services
MIT License
20 stars 8 forks source link

`RemoteServiceBroker` should clear the `ServiceActivationOptions.multiplexingStream` in `getPipe` #100

Open AArnott opened 1 year ago

AArnott commented 1 year ago

When the RemoteServiceBroker is preparing to serialize a service request, it should ensure it does not attempt to serialize the MultiplexingStream object that may be present in the ServiceActivationOptions.multiplexingStream property lest an error like this be thrown:

Converting circular structure to JSON
    --> starting at object with constructor 'MultiplexingStreamClass'
    |     property 'locallyOfferedOpenChannels' -> object with constructor 'Object'
    |     property '1' -> object with constructor 'ChannelClass'
    --- property '_multiplexingStream' closes the circle