search

microsoft / vs-servicehub

The service broker libraries used by Visual Studio to exchange intra- and inter-process services
MIT License
21 stars 8 forks source link

Update ThirdPartyNotice.txt file #87

Closed RyanToth3 closed 1 year ago

RyanToth3 commented 1 year ago

I didn't know our pipeline was doing it automatically, I was just following the directions on the compliance work item. I did generate this file automatically using CG though. I'll get this checked in anyways just to cover my bases.

AArnott commented 1 year ago

Generation of the NOTICE file doesn't equate to shipping it in the NPM package. IMO the ideal fix for this would be to remove the manually constructed NOTICE file, and adjust the pipeline to drop the NOTICE file (or a copy of it at least) that is generated by the pipeline into the NPM directory before it is packed. Then you never have to manually update again.