search

microsoft / vs-streamjsonrpc

The StreamJsonRpc library offers JSON-RPC 2.0 over any .NET Stream, WebSocket, or Pipe. With bonus support for request cancellation, client proxy generation, and more.
Other
730 stars 149 forks source link

Add TFM to enable reduction in explicit dependencies #1032

Closed thompson-tomo closed 4 months ago

thompson-tomo commented 4 months ago

Is your feature request related to a problem? Please describe.

I want to minimise dependencies in my project by utilising framework dependencies wherever possible

Describe the solution you'd like

I want the package to not have a dependencies on packages which can be provided by the framework (net 6/net core 3) ie System.Text.Json

Describe alternatives you've considered

Accept the additional dependency

Additional context

No response

AArnott commented 4 months ago

@thompson-tomo I see you've filed almost identical issues across several repos. Are you actually impacted by this, or are you just filing issues against repos to achieve a goal you have for all libraries to do this? I ask because we want to prioritize customer-filed issues that actually matter to them.

thompson-tomo commented 4 months ago

@AArnott yes i have run into issues with conflicting STJ versions due to it being explicitly provided and at the same time for my work project our dependencies are analyzed for vulnerabilities & currentness. The most efficent to achieve that is by leveraging the framework wherever possible. I have already submitted a PR for the change like i have done for a number of the issues i have filled and i will continue submitting PR's if no one does it before i get to it.