Fix exceptions being thrown when ETW attempts to log messages with System.Text.Json

microsoft / vs-streamjsonrpc

The StreamJsonRpc library offers JSON-RPC 2.0 over any .NET Stream, WebSocket, or Pipe. With bonus support for request cancellation, client proxy generation, and more.

Other

730 stars 149 forks source link

Fix exceptions being thrown when ETW attempts to log messages with System.Text.Json #1039

Closed dibarbet closed 4 months ago

dibarbet commented 4 months ago

I took a stab at fixing https://github.com/microsoft/vs-streamjsonrpc/issues/1038

Before my fix, the test I added fails with the same System.Text.Json.JsonException : Unexpected value kind for arguments: Object I'm seeing in the roslyn insertion.

I haven't figured out how to test the change in VS however

AArnott commented 4 months ago

Thanks for the investigation and taking a stab at the fix. However, your fix just avoids an exception without solving the underlying problem. Closing in favor of #1040.