search

microsoft / vscode-ai-toolkit

MIT License
1.22k stars 65 forks source link

olive-config.json generated with wrong decimal separator #73

Closed sebug closed 4 months ago

sebug commented 5 months ago

On Windows with Regional format French (Switzerland), when running the model fine-tuning wizard, the generated config file olive-config.json is not valid JSON - it uses the comma instead of the dot as decimal separator for float values in the JSON:

[snip] "passes": { "qlora": { "type": "QLoRA", "config": { "compute_dtype": "bfloat16", "quant_type": "nf4", "double_quant": true, "lora_r": 64, "lora_alpha": 64, "lora_dropout": 0,1, "train_data_config": "dataset_default_train", "eval_dataset_size": 0,3, "training_args": { "seed": 0, "data_seed": 42,

[snip]

note the "lora_dropout": 0,1

swatDong commented 4 months ago

@sebug could you please try the newer version (0.3.2) of the extension? It should be already fixed.

sebug commented 4 months ago

Hello, yes, I confirm that with version v0.3.2 pre-release the generated JSON is valid. Thanks.