search

microsoft / vscode-anycode

MIT License
326 stars 38 forks source link

Fail graceful when indexedDB isn't available #36

Closed hslee2008 closed 2 years ago

hslee2008 commented 2 years ago

Browser

Brave Browser 1.37.116 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/100.0.4896.127 Safari/537.36 In https://vscode.dev

What is happening

It seems like anycode extension is dependent on https://vortex.data.microsoft.com/collect/v1 as when this tracker/script is blocked, anycode logs 2 errors upon entering website. The user denied permission to access the database. Request initialize failed with message: The user denied permission to access the database.

And upon opening webview, the following error was logged. The following error is logged everytime the window change. Error: Could not register service workers: NotSupportedError: Failed to register a ServiceWorker for scope

What should change

This was not the case a few months ago and I believe something changed from then and now. But it seems like upong entering, opening repo, opening local file e.t.c. in vscode.dev. Are there any ways to fix this error? Or maybe supress this error in the future?

Error Message

Message: Request initialize failed with message: The user denied permission to access the database.
Code: -32603 
Message: Request initialize failed with message: The user denied permission to access the database.
Code: -32603 
Error loading webview: Error: Could not register service workers: NotSupportedError: Failed to register a ServiceWorker for scope ('https://11hn10heo6midq2kg6lokmomd3ob1qr0qej5b3uotsfsv2d066p7.vscode-webview.net/stable/dfd34e8260c270da74b5c2d86d61aee4b6d56977/out/vs/workbench/contrib/webview/browser/pre/') with script ('https://11hn10heo6midq2kg6lokmomd3ob1qr0qej5b3uotsfsv2d066p7.vscode-webview.net/stable/dfd34e8260c270da74b5c2d86d61aee4b6d56977/out/vs/workbench/contrib/webview/browser/pre/service-worker.js?v=4&vscode-resource-base-authority=vscode-resource.vscode-webview.net&remoteAuthority='): The user denied permission to use Service Worker..

Clarification

This error is only logged in Brave Browser when it blocks tracker https://vortex.data.microsoft.com/collect/v1

jrieken commented 2 years ago

anycode uses indexeddb to cache results across sessions. When that browser API isn't available it fails and doesn't recover... I could failure more graceful instead...

jrieken commented 2 years ago

/cc @digitarald you also ran into this