microsoft / vscode-arduino

Visual Studio Code extension for Arduino
Other
1.16k stars 215 forks source link

Using the build.extra_flags option on v0.6.0 breaks verify on SAMD #1647

Open GregTerrell opened 1 year ago

GregTerrell commented 1 year ago

Adding buildPreferences|build.extra_flags to arduino.json file breaks Verify.

Can be reproduced with blink.ino

Using the blink.ino modifying arduino.json to...

{ "board": "adafruit:samd:adafruit_feather_m0_express", "configuration": "usbstack=arduino,debug=on", "port": "COM16", "sketch": "Blink.ino", "output": "build", "buildPreferences": [ [ "build.extra_flags", "-DMY_DEF=222" ] ] }

Causes verify to fail. The errors seem to be focused around USB and sercom. Using an Adafruit Feather M0 Express dev board.

GregTerrell commented 1 year ago

The failing step in the build is "Compiling sketch...". Just starting the comparison here, but the failing command line is missing several defines around USB topic.

Builds "C:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\tools\\arm-none-eabi-gcc\\9-2019q4/bin/arm-none-eabi-g++" -mcpu=cortex-m0plus -mthumb -c -g -Os -w -std=gnu++11 -ffunction-sections -fdata-sections -fno-threadsafe-statics -nostdlib --param max-inline-insns-single=500 -fno-rtti -fno-exceptions -MMD "-D__SKETCH_NAME__=\"\"\"Blink.ino\"\"\"" -DF_CPU=48000000L -DARDUINO=10607 -DARDUINO_SAMD_FEATHER_M0_EXPRESS -DARDUINO_ARCH_SAMD -DARDUINO_SAMD_ADAFRUIT -DARDUINO_SAMD_ZERO -DARDUINO_SAMD_FEATHER_M0 -DARM_MATH_CM0PLUS -DADAFRUIT_FEATHER_M0_EXPRESS -D__SAMD21G18A__ -DUSB_VID=0x239A -DUSB_PID=0x801B -DUSBCON -DUSB_CONFIG_POWER=100 "-DUSB_MANUFACTURER=\"Adafruit\"" "-DUSB_PRODUCT=\"Feather M0 Express\"" -g "-IC:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\hardware\\samd\\1.7.5/libraries/Adafruit_TinyUSB_Arduino/src/arduino" -g -Og -g -DARDUINO_SAMD_ZERO -DARDUINO_SAMD_FEATHER_M0 -DARM_MATH_CM0PLUS -DADAFRUIT_FEATHER_M0_EXPRESS -D__SAMD21G18A__ -DUSB_VID=0x239A -DUSB_PID=0x801B -DUSBCON -DUSB_CONFIG_POWER=100 "-DUSB_MANUFACTURER=\"Adafruit\"" "-DUSB_PRODUCT=\"Feather M0 Express\"" -g "-IC:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\hardware\\samd\\1.7.5/libraries/Adafruit_TinyUSB_Arduino/src/arduino" "-IC:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\tools\\CMSIS\\5.4.0/CMSIS/Core/Include/" "-IC:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\tools\\CMSIS\\5.4.0/CMSIS/DSP/Include/" "-IC:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\tools\\CMSIS-Atmel\\1.2.2/CMSIS/Device/ATMEL/" "-IC:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\hardware\\samd\\1.7.5\\cores\\arduino" "-IC:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\hardware\\samd\\1.7.5\\variants\\feather_m0_express" "c:\\Users\\GregTerrell\\Documents\\CodeDev\\Arduino\\Blink\\build\\sketch\\Blink.ino.cpp" -o "c:\\Users\\GregTerrell\\Documents\\CodeDev\\Arduino\\Blink\\build\\sketch\\Blink.ino.cpp.o" Fails "C:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\tools\\arm-none-eabi-gcc\\9-2019q4/bin/arm-none-eabi-g++" -mcpu=cortex-m0plus -mthumb -c -g -Os -w -std=gnu++11 -ffunction-sections -fdata-sections -fno-threadsafe-statics -nostdlib --param max-inline-insns-single=500 -fno-rtti -fno-exceptions -MMD "-D__SKETCH_NAME__=\"\"\"Blink.ino\"\"\"" -DF_CPU=48000000L -DARDUINO=10607 -DARDUINO_SAMD_FEATHER_M0_EXPRESS -DARDUINO_ARCH_SAMD -DARDUINO_SAMD_ADAFRUIT -DLQC_NTWK=1 -g -Og -g -DLQC_NTWK=1 "-IC:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\tools\\CMSIS\\5.4.0/CMSIS/Core/Include/" "-IC:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\tools\\CMSIS\\5.4.0/CMSIS/DSP/Include/" "-IC:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\tools\\CMSIS-Atmel\\1.2.2/CMSIS/Device/ATMEL/" "-IC:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\hardware\\samd\\1.7.5\\cores\\arduino" "-IC:\\Users\\GregTerrell\\AppData\\Local\\Arduino15\\packages\\adafruit\\hardware\\samd\\1.7.5\\variants\\feather_m0_express" "C:\\Users\\GregTerrell\\Documents\\CodeDev\\Arduino\\Blink\\build\\sketch\\Blink.ino.cpp" -o "C:\\Users\\GregTerrell\\Documents\\CodeDev\\Arduino\\Blink\\build\\sketch\\Blink.ino.cpp.o"