microsoft / vscode-atom-keybindings

Port of Atom Keybindings for VS Code.
MIT License
145 stars 59 forks source link

some documented key bindings do not work at all #78

Open jabielecki opened 2 years ago

jabielecki commented 2 years ago

Problem

Many key bindings documented in the README.md are not actually present on a fresh install on Linux.

I've listed just the ones interesting for me personally below. The ones marked missing are neither actually working nor shown in the VSCode Feature Contributions listing. It is confusing to have them prominently documented - the top ones are the first thing visible just after installing this plugin.

Command Linux Comment
cursorLeftSelect ctrl+shift+b missing
cursorRightSelect ctrl+shift+f missing
cursorUpSelect ctrl+shift+p missing
cursorDownSelect ctrl+shift+n missing
cursorWordEndRight alt+f missing
cursorWordStartLeft alt+b missing
cursorWordEndRightSelect shift+alt+f missing
cursorWordStartLeftSelect shift+alt+b missing
cursorEndSelect ctrl+shift+e missing
cursorHomeSelect ctrl+shift+a missing
editor.action.joinLines ctrl+j present
editor.action.copyLinesDownAction ctrl+shift+d present
editor.action.deleteLines ctrl+shift+k present
editor.action.jumpToBracket ctrl+m present
editor.action.showSnippets alt+shift+s present
editor.action.format ctrl+shift+i present
editor.action.insertCursorAtEndOfEachLineSelected alt+shift+l present
markdown.showPreviewToSide ctrl+shift+m present
workbench.action.editor.changeLanguageMode ctrl+shift+l present
workbench.action.reloadWindow alt+ctrl+r present
workbench.action.toggleDevTools ctrl+alt+i present
workbench.action.files.openFolder ctrl+shift+o present
workbench.action.showAllEditors ctrl+b present

Printscreen

Screenshot from 2022-01-19 14-18-03

Versions

Plugin

v3.0.9

VSCode

Version: 1.63.2
Commit: 899d46d82c4c95423fb7e10e68eba52050e30ba3
Date: 2021-12-15T09:39:46.686Z
Electron: 13.5.2
Chromium: 91.0.4472.164
Node.js: 14.16.0
V8: 9.1.269.39-electron.0
OS: Linux x64 5.4.0-94-generic snap

Linux

Ubuntu 20.04 LTS (with current patches per 2021-01-19).
NickStees commented 1 year ago

Same for me I use these quite often and they stopped working recently

NickStees commented 1 year ago

Trying Ctrl+Shift+d give the following debug

2023-04-25 11:15:11.268 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-04-25 11:15:11.269 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-04-25 11:15:11.269 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 17, key: Control
2023-04-25 11:15:11.269 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl], code: ControlLeft, keyCode: 5 ('Ctrl')
2023-04-25 11:15:11.270 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-04-25 11:15:11.395 [info] [KeybindingService]: / Soft dispatching keyboard event
2023-04-25 11:15:11.396 [info] [KeybindingService]: \ Keyboard event cannot be dispatched
2023-04-25 11:15:11.396 [info] [KeybindingService]: / Received  keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 16, key: Shift
2023-04-25 11:15:11.396 [info] [KeybindingService]: | Converted keydown event - modifiers: [ctrl,shift], code: ShiftLeft, keyCode: 4 ('Shift')
2023-04-25 11:15:11.396 [info] [KeybindingService]: \ Keyboard event cannot be dispatched in keydown phase.
2023-04-25 11:15:11.822 [info] [KeybindingService]: + Ignoring single modifier shift due to it being pressed together with other keys.

Also looked at https://github.com/microsoft/vscode/wiki/Keybinding-Issues but not sure I found anything related to 'Ignoring single modifier shift due to it being pressed together with other keys.'

NickStees commented 1 year ago

All my googling has lead me to possibly that the OS is using these keybindings? https://github.com/microsoft/vscode/issues/136230