Open v-mengwe opened 2 years ago
@v-mengwe that notification will only be shown if the extension has been activated and you change the auth library setting. Is the Azure View open when you change this setting? Or has the extension not activated yet? In my testing the notification is shown on Codespaces once the extension is activated.
The "Azure: Authentication Library" setting returns to "ADAL" when clicking anywhere with the mouse.
This concerns me. I'm not able to repro it but could you describe this behavior some more?
I'm sorry for missing a detail, the step 2 is to set the "Azure: Authentication Library" setting to "MSAL" for "User", not "Remote [Codespaces]". This should be the reason why it cannot be reproduced.
What is the difference between "User" and "Remote [Codespaces]"? Can you help share?
No worries, @v-mengwe. I looked into this using the latest commit (af40115544e7ef52c38d97df332a1b09122ac1a7) and saw that the Azure: Authentication Library
setting is not available in user settings on Codespaces in the browser. It only appears in remote settings for me:
We added the machine-overridable
scope to the auth library setting here which limits that setting to the current machine (i.e. prevents settings sync).
machine-overridable - Machine specific settings that can be overridden by workspace or folder settings. (source)
It appears that Codespaces interprets that scope to mean "don't allow this setting to be changed in user settings on Codespaces".
Can you verify that those screenshots were taken using the latest build? I believe the Azure: Authentication Library
settings should only show up in user settings on Codespaces prior to this commit: a030d48803380027fddd87733b7bbef3f7cb77b9
Verified on the latest build 20220228.1. User Settings The "Azure: Authentication Library" setting returns to "ADAL" when clicking anywhere with the mouse.
Remote Settings The notification 'You must sign out and reload the window to authenticate with "MSAL"' pops up when changing the setting from "ADAL" to "MSAL".
I tried again with build 20220228.1 on a freshly created Codespace in both Brave and Edge and I still don't see the Azure: Authentication Library
setting in user settings. It does show up in remote settings though.
This was still the case after I enabled settings sync.
I see the auth library setting in user settings when I revert to a build prior to commit https://github.com/microsoft/vscode-azure-account/commit/a030d48803380027fddd87733b7bbef3f7cb77b9 such as 20220210.20. Is it possible that the version of Azure Account installed in that Codespace is outdated? If not we potentially need to investigate why in some cases that setting is appearing in user settings.
I found a very strange phenomenon, the user settings display "No Settings Found" when typing "Azure: Authentication Library" to search, but the "Azure: Authentication Library" dispalys by expanding the user settings.
Excellent find, @v-mengwe! I'm able to repro the issue now.
This is a Codespaces problem and I don't think that setting should even be shown for user settings. We'll discuss what to do with this issue in triage today.
OS: Codespaces Build Version: v0.10.0 Regression: Not a regression
Repro Steps:
Expect: The notification 'You must sign out and reload the window to authenticate with "MSAL"' pops up.
Actual: The notification 'You must sign out and reload the window to authenticate with "MSAL"' does not pop up.
More Info: