microsoft / vscode-azure-iot-edge

Azure IoT Edge for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=vsciot-vscode.azure-iot-edge
Other
51 stars 36 forks source link

CreateOption parse error when there is line break in the createoption string #278

Closed adashen closed 5 years ago

adashen commented 5 years ago

Detail could be found at https://github.com/Microsoft/vscode-azure-iot-edge/pull/275

czgtest commented 5 years ago

@adashen I create new solution for nodejs module and replace createOptions value as bellow.

  1. build and push IoT edge solution successfully.
  2. create deployment for single device 3.moniter D2C message for device

test pass on edge runtime

"createOptions": "{\r\n\"ExposedPorts\":{\r\n\"9229/tcp\":{}},\"HostConfig\":{\"PortBindings\":{\"9229/tcp\":[{\"HostPort\":\"9229\"\r\n}\r\n]\r\n}\r\n}\r\n}\r\n "

image

czgtest commented 5 years ago

this fix work well on both edge runtime and simulator, so close it.