microsoft / vscode-azureapicenter

MIT License
17 stars 13 forks source link

fix: do not send sub data when no sub selected #265

Closed wenytang-ms closed 1 month ago

wenytang-ms commented 1 month ago

https://github.com/microsoft/vscode-azuretools/blob/02c16b920e7970fc14b76d30044021c22908e82a/utils/src/tree/AzExtTreeItem.ts#L154 the ext pkg direct throw error when no sub

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 45.45%. Comparing base (21d179f) to head (d46214b). Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/utils/telemetryUtils.ts 85.71% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/265/graphs/tree.svg?width=650&height=150&src=pr&token=TIJgHIZNDD&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft)](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/265?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) ```diff @@ Coverage Diff @@ ## main #265 +/- ## ======================================= Coverage 45.44% 45.45% ======================================= Files 92 92 Lines 5813 5819 +6 Branches 134 135 +1 ======================================= + Hits 2642 2645 +3 - Misses 3171 3174 +3 ``` | [Files with missing lines](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/265?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft) | Coverage Δ | | |---|---|---| | [src/utils/telemetryUtils.ts](https://app.codecov.io/gh/microsoft/vscode-azureapicenter/pull/265?src=pr&el=tree&filepath=src%2Futils%2FtelemetryUtils.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=microsoft#diff-c3JjL3V0aWxzL3RlbGVtZXRyeVV0aWxzLnRz) | `90.00% <85.71%> (-10.00%)` | :arrow_down: |