search

microsoft / vscode-azurecli

VS Code extension for the Azure CLI 2.0
MIT License
71 stars 47 forks source link

Fix for PYTHONPATH on Homebrew #31

Closed chrmarti closed 6 years ago

chrmarti commented 6 years ago

Less hardcoded paths than in #30.

chrmarti commented 6 years ago

@derekbekoe Could you take a look at my additions and let me know if that makes sense? Will there be more than one version of packages in .../libexec/lib? Thanks.

derekbekoe commented 6 years ago

Yes there can be more than one version:

screen shot 2018-03-07 at 9 51 10 am
chrmarti commented 6 years ago

@derekbekoe What about the python folders in .../libexec/lib? Can there be more than one? I wonder if the code to find that could be simplified.

derekbekoe commented 6 years ago

There will only be one as it's part of the homebrew formula definition. See https://github.com/Homebrew/homebrew-core/blob/ed778ce0ec422a9ff768abbd01dc54f787dadaca/Formula/azure-cli.rb#L486

I would be surprised to see more than one.

chrmarti commented 6 years ago

Merged squashed versions of our commits. Thanks @derekbekoe!