search

microsoft / vscode-azurecontainerapps

Azure Container Apps extension for VS Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurecontainerapps
MIT License
34 stars 13 forks source link

Better ingress detection/prompting #310

Open MicroFish91 opened 1 year ago

MicroFish91 commented 1 year ago

Say I use a quickstart image and the port number exposed is 80. Later I redeploy a new image that needs port 3000 exposed... right now we do not prompt for the port # again and have to manually change the number through Edit target port.... There's probably a couple things we can do here to improve the experience. We can always re-prompt for the port or re-prompt conditionally. When a Dockerfile is detected we could also smart detect/suggest the port based on the Dockerfile if it is included as part of the build.

If we want to do only conditional re-prompting, these are some obvious candidates:

nturinski commented 1 year ago

This could also be considered as part of this work: https://github.com/microsoft/vscode-azurecontainerapps/issues/311

Adding or updating an image may still be considered "creating a revision" until you actually deploy it, in which case, it'd be tracked in the JSON envelope.

alexweininger commented 1 year ago

It would be nice if there was a standard way for us to tell what ports need to be exposed from an image. Not sure if that exists...

nturinski commented 1 year ago

Maybe we can prompt the user for target port only if the image changes. If only the tag is updated, then don't prompt the user for the port.

MicroFish91 commented 1 year ago

That makes sense. We should definitely re-discuss how this flow changes with our new batch revision update format. We might be able to check for new images on the draft template when we run deploy draft or whatever we end up actually calling the command.