microsoft / vscode-azurefunctions

Azure Functions extension for VS Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions
MIT License
291 stars 132 forks source link

A11y_AzureToolsforVSCode_AzureFunction_CreateFunctionAppinAzure_ScreenReader: The NVDA is not announcing "Create Function App in Azure" header text of "Create Function App in Azure" dialog. #2942

Open 12-shweta opened 3 years ago

12-shweta commented 3 years ago

Actual:

When we activate the "Create Function App in Azure" control the NVDA only announces "edit Enter a globally unique name for the new function app. (Press 'Enter' to confirm or 'Escape' to cancel) blank" but it does not announce the header text that is "Create Function App in Azure (1/3)".

This issue is also observed with JAWS. This issue is also observed with scenarios such as "Create new project" and "Create Function App in Azure(Advanced) (1/7)" dialog

Expected:

After activating the "Create Function App in Azure" control the NVDA should announce "Create Function App in Azure(1/3)" header text.

GitHubTags:#A11yMAS;#A11yTCS;#BM_AzureToolsforVSCode_Win32_Aug2021;#Azure Tools for VS Code;#A11ySev3;#WCAG1.3.1;#DesktopApp;#Win10;#NVDA;#JAWS;#Element:Header;#Linked:Bug138120;

Environment Details:

Visual Studio Code Azure Function Operating System: Windows 10 Pro 21H1 Screen Reader: NVDA(2021.1),JAWS(2021.2107.12 ILM)

Steps to Reproduce:

  1. Launch the Visual studio code.
  2. TAB to on "Extension" button and search for "Azure Functions" and select it using ENTER key.
  3. "Azure Function" screen should open. TAB to "Install" button and hit ENTER key to install it.
  4. "Azure" button will appear in navigation pane. TAB to it and select it.
  5. Start NVDA.
  6. TAB to any Subscription and expand options using Shift+F10 then TAB to "Create Function App in Azure" control and select it.
  7. Observe the announcement by screen reader after activating the "Create Function App in Azure" control.

User Impact:

The screen reader users won't be able to understand which popup or dialog they are navigating.

Check out Accessibility Insights! - Identify accessibility bugs before check-in and make bug fixing faster and easier.”

nturinski commented 2 years ago

This is a duplicate of https://github.com/microsoft/vscode-azurefunctions/issues/2691. As mentioned in the original issue, please file an external issue to VS Code (https://github.com/microsoft/vscode/issues)

12-shweta commented 2 years ago

@nturinski Logged a new external bug https://github.com/microsoft/vscode/issues/138120 mentioned for above URL

jinglouMSFT commented 2 years ago

The VS Code bug was closed due to lack of a generic repro step. The issue is similar to VS Code command: Git: Clone, where the content of the wizard is not read.

12-shweta commented 2 years ago

@jinglouMSFT As you comment "The issue is similar to VS Code command: Git: Clone, where the content of the wizard is not read." so whether there is any bug logged to track this issue ? And if this one is fixed then the primary bug will also be fixed?

12-shweta commented 2 years ago

@jinglouMSFT Could you please look into the above comment

MicroFish91 commented 2 years ago

Just to echo and summarize some of the above comments - this issue was originally a duplicate that was closed and outside of the scope of the extensions team; however, I had previously put in a similar issue to the VS Code team which should cover the issue presented here.

Please see reference to the upstream issue here: https://github.com/microsoft/vscode/issues/149387

Thank you :)

12-shweta commented 2 years ago

@MicroFish91 The tracking issue has been closed but when we are checking on the Visual studio code we are still able to reproduce the issue, could you please tell us when fixes will be available for this issue.

MicroFish91 commented 2 years ago

Upstream issue we are tracking against is still open and being investigated, see previous comment's reference to issue 149387

jinglouMSFT commented 2 years ago

@MicroFish91 @12-shweta VS Code has closed the bug as merged. Although the solution doesn't seem to be 100% reliable. Can you try this in the Functions extension? Make sure you comment on #149387 in vscode. Thanks.

MicroFish91 commented 2 years ago

I ran and tested with 1.68 and the title field is now being picked up and read

12-shweta commented 2 years ago

Verified the issue in 1.68 but still is reproducible. image

MicroFish91 commented 2 years ago

Verified the issue in 1.68 but still is reproducible. image

When I initially checked on a couple titles it was working, but I'm seeing that this use-case specifically is not working. They mentioned that it wasn't always picked up reliably so this matches up with their note. Let me identify which use-cases the aria label for the title is not being read and discuss with the VS Code team. I will get back to you after, thank you for your help!

MicroFish91 commented 2 years ago

Short update, talked with Isidor in the posted issue thread above... solution will likely need to be resolved further upstream, so we will continue tracking, thanks

MicroFish91 commented 1 year ago

Another quick update, talked with Isidor and it looks like this will be investigated further in the November milestone for VS Code

MicroFish91 commented 1 year ago

@12-shweta Hi, I was wondering if this could be downgraded to Sev3 based on new guidelines. This issue has the same upstream tracking dependency as this issue which was also downgraded to Sev3.

Thank you!

Edit: Both issues can be traced back to here

12-shweta commented 1 year ago

Downgrading the severity as per New Severity guidelines.

jinglouMSFT commented 1 year ago

@12-shweta This issue is showing up in S360 tracking in 12/5/2022's report. Can you make sure this issue has been correctly downgraded to Sev3? Sev3 shouldn't be tracked in S360. Thanks.

12-shweta commented 1 year ago

We have lowered the severity of this bug but seems to be it got stale, will check with the team

MicroFish91 commented 2 months ago

Upstream issue has been resolved, can you confirm and close if so? Thank you!