search

microsoft / vscode-azurefunctions

Azure Functions extension for VS Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions
MIT License
290 stars 131 forks source link

Add new command `deployByFunctionAppId` #4125

Closed MicroFish91 closed 1 month ago

MicroFish91 commented 1 month ago

One or more teams currently leverage our deploy command directly using commands.executeCommand. We previously allowed the functionAppId target to be passed as a third argument into deployProductionSlot. Upon investigation, I noticed that only the first arg was being passed down when wrapped with registerCommandWithTreeNodeUnwrapping.

Calling with registerCommand instead seems to preserve all args. As a workaround, I have created a command for these teams to utilize directly where the only thing you need to pass it is the functionAppId. This is probably better also because they are not really ever passing a tree item anyway, so we don't ever need to unwrap for their use-case.

nturinski commented 1 month ago

Confirmed with partner team that needs this that it's working. We're having another issue with the defaultHostname thing, but that's unrelated to these changes.