microsoft / vscode-azurefunctions

Azure Functions extension for VS Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurefunctions
MIT License
291 stars 132 forks source link

Succeed to deploy a JavaScript project to a .NET Flex Consumption function app without any error #4156

Open v-ruizh opened 4 months ago

v-ruizh commented 4 months ago

OS: All Build Version: v1.15.1-alpha.0 Regression: Not a Regression

Repro Steps:

  1. Create a JavaScript project with Http Trigger template.
  2. Create a Flex Consumption function app with another runtime, such as .NET 8 isolated.
  3. Deploy the JavaScript project to the above .NET Flex Consumption function app.
  4. Check whether fail to deploy a JavaScript project to a .NET Flex Consumption function app with an error.

Expect: Fail to deploy a JavaScript project to a .NET Flex Consumption function app with an error, such as the below one. image

Actual: Succeed to deploy a JavaScript project to a .NET Flex Consumption function app without any error. image

More Info:

  1. This issue also reproduces when deploying a JavaScript project to a Python/Java/PowerShell Flex Consumption function app.
  2. There is no application setting "FUNCTIONS_WORKER_RUNTIME" in Flex Consumption function app. image
nturinski commented 4 months ago

Great catch. There should be a different property that we can check for flex apps in order to get the runtime information.

JustinGrote commented 1 month ago

Happened to me too, the extension should filter uploading these settings in a flex consumption environment