microsoft / vscode-azureresourcegroups

VS Code extension for managing Azure resources.
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azureresourcegroups
MIT License
53 stars 28 forks source link

(Accessibility) Yellow-on-white icon for KeyVaults is hard to see #173

Open bwateratmsft opened 2 years ago

bwateratmsft commented 2 years ago

The yellow-on-white icon for KeyVaults is not easy to see clearly:

image

nturinski commented 2 years ago

Should we actually support having a light/dark theme icon for each Azure Resource? Currently we just have one icon per resource.

bwateratmsft commented 2 years ago

This is on the dark theme--the icon contains a white circle. It'd look the same on light theme.

We should try to get a better icon than this (that looks good on both light and dark themes), and if one doesn't exist, ask them to make a better one.

nturinski commented 2 years ago

Yeah, I meant like how a lot of our extensions have a light/dark resource folder such as Functions https://github.com/microsoft/vscode-azurefunctions/tree/main/resources. Would definitely be better to just have one that looks good on both though.