Extension hijacks "Toggle Block Comment" keyboard shortcut

Zache commented 3 months ago

This extension registers the keyboard shortcut: Shift+Alt+A to open itself in sidebar of VSCode, but that keyboard shortcut is already used by the default configuration of VSCode as "Toggle Block Comment" that comments out your current selection.

To me this feels like bad manners, and I think you should change it.

Looking at the keyboard shortcuts it seems like focusing the different sidebars uses Ctrl+Shift and not Shift+Alt. Perhaps it's better to follow that pattern? Ctrl+Shift+A is already taken (but only works when a notification is focused or a toast visible), but I can see that GitLens has opted for a chord and selected Ctrl+Shift+G G instead of hijacking the default shortcut for "View: Show Source Control"

alexweininger commented 3 months ago

I agree that we should try to not overlap with the toggle block comment keybind.

What operating system are you using? I'm asking because I think this issue is specific to Windows or Linux. On macOS, we don't overlap with toggle block comment.

This is the configuration for our keybind:

{
    "command": "workbench.view.extension.azure",
    "key": "ctrl+shift+a",
    "mac": "cmd+shift+a",
    "linux": "shift+alt+a"
}

Zache commented 3 months ago

Windows

On Wed, 5 Jun 2024 at 19:06, Alex Weininger @.***> wrote:

What operating system are you using?

— Reply to this email directly, view it on GitHub https://github.com/microsoft/vscode-azureresourcegroups/issues/870#issuecomment-2150551309, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3AXQEJODNVFHLDJ7EFMADZF5AR5AVCNFSM6AAAAABIZ7QOPKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNJQGU2TCMZQHE . You are receiving this because you authored the thread.Message ID: @.***>

alexweininger commented 3 months ago

This has been fixed in #876

microsoft / vscode-azureresourcegroups

Extension hijacks "Toggle Block Comment" keyboard shortcut #870