search

microsoft / vscode-azureresourcegroups

VS Code extension for managing Azure resources.
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azureresourcegroups
MIT License
54 stars 29 forks source link

"Sign in to Directory..." shows in Azure Resources view after signing in with MSAL #935

Open v-ruizh opened 1 month ago

v-ruizh commented 1 month ago

OS: All Build Version: 20241004.1 Regression: Not a regression

Repro Steps:

  1. Enable the setting "Microsoft: Use Msal". Image
  2. Click "Sign in to Azure..." in Azure Resources view and sign in with Azure Account.
  3. Check whether the subscriptions are listed in Azure Resources view.

Expect: The subscriptions are listed in Azure Resources view.

Actual: "Sign in to Directory..." shows in Azure Resources view. Image

More Info:

  1. This issue does not reproduce if the setting "Microsoft: Use Msal" is disabled.
  2. Click "Sign in to Directory..." to sign in again, the subscriptions will be listed.
alexweininger commented 1 month ago

We think this is due to a recent change in VS Code. Which version of VS Code are you using to reproduce this issue? Could you try reverting versions until it doesn't reproduce?

v-ruizh commented 1 month ago

@alexweininger We use the latest VS Code "1.94.1" to reproduce this issue. Verified the previous VS Code "1.93.1", this issue also reproduces in this VS Code. This may be caused by the setting "Microsoft: Use Msal" was added from VS Code "1.93.1", this issue will reproduce if enable this setting to sign in. Image

There is no setting "Microsoft: Use Msal" in VS Code "1.92.2", so this issue does not reproduce in VS Code "1.92.2".