search

microsoft / vscode-azurestaticwebapps

Azure Static Web Apps extension for VS Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurestaticwebapps
MIT License
86 stars 33 forks source link

The Azure Functions extension is not installed directly after clicking the "Install" button in the notification #569

Open v-mengwe opened 2 years ago

v-mengwe commented 2 years ago

OS: All Build Version: 20211105.14 Regression: Not a regression

Repro Steps:

  1. Make sure the Azure Functions extension is not installed in VS Code.
  2. Install Azure Static Web Apps extension in VS Code -> Open a reactsite project in VS Code -> Click "Create HTTP Function" button.
  3. A notification pops up asking to install the Azure Functions extension -> Click "Install" button.
  4. Check whether the Azure Functions extension is installed directly.

Expect: The Azure Functions extension is installed directly.

Actual: The Azure Functions extension is not installed directly. function1

More Info: Make sure the Azure Functions extension is not installed in VS Code -> Install Azure Static Web Apps extension in VS Code -> Open a reactsite project in VS Code -> A notification pops up automatically asking to install the Azure Functions extension -> Click "Install" button -> The Azure Functions extension is installed directly. function

nturinski commented 2 years ago

@alexweininger Isn't there a command we could execute to just install the extension for them? I know that there's still a VS Code prompt, but that might be a smoother experience than taking them to the marketpage 🤔

alexweininger commented 2 years ago

I assumed there was a reason we did it this way instead of that way. Maybe to give the user more information about the extension they are about to install before they are given an "install or cancel" prompt.

nturinski commented 2 years ago

Well, I don't think we knew about the vscode command at the time we made the pattern (it was a few years ago for App Service/Databases). But that is a good point.