search

microsoft / vscode-azurestaticwebapps

Azure Static Web Apps extension for VS Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurestaticwebapps
MIT License
88 stars 35 forks source link

There is an extra log in the `start vue-basic-api` terminal after closing the opened webpage #689

Open v-mengwe opened 2 years ago

v-mengwe commented 2 years ago

OS: M1/Linux Build Version: 20220513.1 CLI Version: 1.0.0-preview

Repro Steps:

  1. Clone https://github.com/alexweininger/vue-basic-api -> Open the project in VS Code.
  2. Open VS Code terminal and run "npm install".
  3. Go to the "Run and Debug" menu -> Select "Azure Static Web Apps…" -> Select "SWA: Run vue-basic-api" -> Click the "Run" button.
  4. Close the opened webpage.
  5. Check whether there is no extra log in the start vue-basic-api terminal.

Expect: There is no extra log in the start vue-basic-api terminal.

Actual: There is an extra log in the start vue-basic-api terminal.

Screen Shot 2022-05-13 at 17 20 25

More Info:

  1. This issue doesn't reproduce on Windows OS.
  2. This issue also reproduces for below projects: https://github.com/staticwebdev/angular-basic https://github.com/alexweininger/angular-basic-api https://github.com/alexweininger/nextjs-basic-api https://github.com/alexweininger/svelte-basic-api https://github.com/alexweininger/angular-basic-dotnet
  3. This issue doesn't reproduce for the ReactSite project. https://github.com/alexweininger/ReactSite
alexweininger commented 2 years ago

Seems like the CLI handles SIGTERM signals differently now, was this behavior intentionally changed @manekinekko @sinedied?

manekinekko commented 2 years ago

We initially didn't handle SIGTERM signals, that was an issue on our end, and we had a bunch of folks reporting that. Now the CLI handles all SIGTERM, SIGINT, exit signals.

Can elaborate more on the issue you are having?