search

microsoft / vscode-azurestaticwebapps

Azure Static Web Apps extension for VS Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurestaticwebapps
MIT License
86 stars 33 forks source link

Update the new language version defaults for Node and .NET APIs #735

Closed Reshmi-Sriram closed 1 year ago

Reshmi-Sriram commented 1 year ago

@nturinski @alexweininger

alexweininger commented 1 year ago

For .NET we currently allow creating .NET 3.1 and .NET 6.0 Functions, and we default to .NET 6.0. We can remove the ability to create .NET 3.1 Functions.

For Node.JS, the only place the runtime version is specified is in the platform.apiRuntime property of the staticwebapp.config.json file. Should we automatically add/edit this property when users create a Node.JS Function?

Reshmi-Sriram commented 1 year ago

Do we not default Node.js to any stack as of today? What happens if a user does not have an apiRuntime property set at all? We need to make that default to 16. We needn't automatically edit the config, we can always ask them to. CC// @vivekjilla

alexweininger commented 1 year ago

Do we not default Node.js to any stack as of today? What happens if a user does not have an apiRuntime property set at all?

@Reshmi-Sriram any updates regarding these questions? The default platforms aren't specified on the docs.

Reshmi-Sriram commented 1 year ago

Hey @alexweininger, Just had a quick call with @vivekjilla and understood how things work for Node. So since we use GHActions to do the build and deploy, we wll be relying on Oryx for the build, and the SWA code will take care of setting the Node default, so we don't have to worry about this on the VSCode side of things. Now that the .NET Core 3.1 changes are in, I think we can close this ticket. Thanks! :)