search

microsoft / vscode-azuretools

Common packages for building Azure extensions for VS Code
MIT License
106 stars 66 forks source link

azure: Filter out storage accounts that deny public requests #1698

Closed nturinski closed 6 months ago

nturinski commented 6 months ago

Fixes https://github.com/microsoft/vscode-azurefunctions/issues/3990

I was able to reproduce both scenarios: publicNetworkAccess is disabled and publicNetworkAccess is enabled but defaultAction is to deny.

As to my comment regarding networkRuleSet-- newer storage accounts use the networkAcls property instead, but the definitions seem to be the same as networkRuleSet. The typings also still using networkRuleSet even after upgrading the storage sdk.