search

microsoft / vscode-azuretools

Common packages for building Azure extensions for VS Code
MIT License
106 stars 66 forks source link

auth: Refactor `AzureDevOpsSubscriptionProvider` so that it accepts values as arguments #1729

Closed hossam-nasr closed 3 months ago

hossam-nasr commented 3 months ago

[auth package] modify the AzureDevOpsSubscriptionProvider and AzureDevOpsSubscriptionProviderFactory so that the three values required to identify the service connection: service connection ID, domain, and client ID, are passed as arguments to the constructor, rather than defaulting to being set as environment variables in the way we currently do. This allows for more versatility and flexibility in the way this provider can be used by other parties and users wanting to do their own E2E testing

alexweininger commented 3 months ago

The most nitpick I've ever done: Can you prefix the PRs like "auth:" instead of "[auth]". We've been doing it that way and I want to stay consistent (as much as possible).

The reasoning is when we generate changelogs on github it's much easier when all the commits are in the same format.

hossam-nasr commented 3 months ago

@alexweininger lol yes done 🫡