microsoft / vscode-azuretools

Common packages for building Azure extensions for VS Code
MIT License
104 stars 66 forks source link

use 'getCode' logic here handled getting the statusCode #77

Open nturinski opened 6 years ago

nturinski commented 6 years ago

use 'getCode' logic here handled getting the statusCode

https://github.com/Microsoft/vscode-azuretools/blob/master/ui/src/parseError.ts#L23

ejizba commented 5 years ago

Still an issue: https://github.com/Microsoft/vscode-azuretools/blob/master/appservice/src/connectToGitHub.ts

const parsedError: IParsedError = parseError(error);
            // The portal returns 200, but is expecting a 204 which causes it to throw an error even after a successful sync
            if (parsedError.message.indexOf('"statusCode":200') === -1) {
                throw error;
            }