Fallback to private IP if unable to find public IP

microsoft / vscode-azurevirtualmachines

Azure Virtual Machines extension for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurevirtualmachines

MIT License

32 stars 20 forks source link

Fallback to private IP if unable to find public IP #264

Closed nturinski closed 3 years ago

nturinski commented 3 years ago

Fixes https://github.com/microsoft/vscode-azurevirtualmachines/issues/172

I'm wondering if it wouldn't be better to just have two separate commands for copying public/private IP address rather than this fallback.

nturinski commented 3 years ago

It probably isn't worth implementing this due to the limitation of not being able to connect to VM's via private IP unless you are within the same virtual network. https://stackoverflow.com/questions/50548826/how-to-ssh-to-azure-vm-using-private-ip-address-from-internet

We can discuss maybe increasing the feature set to include managing virtual networks so that a user could use a network interface controller (NIC) in order to interact with their private VMs.

@fiveisprime What do you think?

nturinski commented 3 years ago

Closing as this doesn't actually resolve anything for users trying to connect to their VM