microsoft / vscode-azurevirtualmachines

Azure Virtual Machines extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=ms-azuretools.vscode-azurevirtualmachines
MIT License
32 stars 20 forks source link

Upgrade Azure sdk and API calls to T2 #301

Closed nturinski closed 2 years ago

nturinski commented 2 years ago

Relies on https://github.com/microsoft/vscode-azuretools/pull/1058/files (for the testing file type error)

Mostly just had to change some API calls and typings.

There were a couple of exceptions, such as createOrUpdate no longer returning the entire object type.

Adding SSH keys also had a new property name. I had a hard time verifying it worked because connecting via SSH is always a huge pain on my sub thanks to the cleanup service, but I can see the VM Extension that we rely on being updated, so I think it is working.

I verified the following were working:

I think that is pretty much all the code it should touch