microsoft / vscode-chrome-debug-core

A library for implementing VS Code debug adapters for targets that implement the Chrome Debugging Protocol.
Other
157 stars 119 forks source link

Now we don't send sourceReference if we can't retrieve the source #527

Closed digeff closed 5 years ago

digeff commented 5 years ago

Before this change we were sending sourceReference for sources we couldn't find the source for. This PR addresses that issue. As an experiment, we implemented this change by inserting a function instead of a class like we normally do. We added some support to be able to do that.

This change won't compile with a required change in chrome-debug: https://github.com/microsoft/vscode-chrome-debug/pull/930

roblourens commented 5 years ago

Integration test failure?