search

microsoft / vscode-chrome-debug-core

A library for implementing VS Code debug adapters for targets that implement the Chrome Debugging Protocol.
Other
157 stars 119 forks source link

Added exception handlers for React Native Hermes debugging #548

Closed RedMickey closed 4 years ago

RedMickey commented 4 years ago

https://github.com/microsoft/vscode-chrome-debug-core/issues/517 The goal of this PR is to fix debugging of React Native Hermes applications via React Native Tools extension. The table below contains the fixes descriptions:

Problem Before the fixes After the fixes Description
The debugger doesn’t show value of numeric variables (Problem №2 - Hermes known issues) Screen Shot 2019-12-25 at 13 38 33 Screen Shot 2019-12-25 at 13 32 20 Added the special condition to handle the case if there isn't description field in a RemoteObject. See getRemoteObjectPreview_primitive method.
The debugger doesn’t show arrays' content (Problem №5 - Hermes known issues) Screen Shot 2019-12-25 at 13 37 40 Screen Shot 2019-12-25 at 13 35 53 Added the handler in case of Runtime.callFunctionOn method returns an empty object. See getNumPropsByEval method.
The debugger doesn’t show functions' content(Problem №1, 4 - Hermes known issues) Screen Shot 2019-12-25 at 13 39 33 Screen Shot 2019-12-25 at 13 33 56 Added the handler in case of RemoteObject with function data doesn't contain description field. See createFunctionVariable method.

For reference: the list of known issues with Hermes debugging for React Native Tools extension.

SounD120 commented 4 years ago

Hi @roblourens . Do you know when this fix will be published in a new chrome-debug-core release? Thanks.

roblourens commented 4 years ago

I have published an update, sorry I meant to do it earlier.