Closed letmaik closed 6 years ago
I updated to VS 15.4 and it works now, but I feel like this should be handled a bit more gracefully.
There's a -nologo
option to VSWhere, but it never seemed to do anything for me (I think newer versions have it implied by -format json
). I can just add it for safety's sake.
How is this related to -nologo
?
I might be wrong. I'm wondering how common this is. I haven't gotten any other reports on it yet, but I'll keep my ears open...
I think you misunderstood the issue. It's not a problem of JSON or -nologo
, it's just that vswhere
throws an error message if you give it any unsupported command line arguments, like -prerelease
which wasn't supported in older versions. Feel free to close the issue, but maybe it would be good to have a fall-back for older versions, so first try with -prerelease
and if that errors, then without it.
Removing -prerelease
here : https://github.com/vector-of-bool/vscode-cmake-tools/blob/develop/src/environment.ts#L305
Solves this issue for me. I have both VS2015 and VS2017 installed.
+1, I just hit this on my machine. Currently on a very limited data connection so I can't try updating the Visual Studio installer at this moment.
@letmaik, you're right, I misunderstood.
I'll have to have a switch to check what vswhere version it is, or maybe bundle the newer version with the extension so that like this don't happen.
0.10.4 now bundles vswhere in the extension, so you should see this issue go away. Tell me if it persists. Sorry about the long wait.
I'm suddenly getting the following error message, probably caused by an update to this extension:
The extension seems to invoke
vswhere
with an unsupported argument-prerelease
. The output of"C:\Program Files (x86)\Microsoft Visual Studio\Installer\vswhere.exe" -all -format json -products * -legacy -prerelease
on my system is:Without
-prerelease
the output is: