microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools
MIT License
1.46k stars 449 forks source link

usepresets context is not set after using quickstart #3734

Closed qarni closed 3 months ago

qarni commented 5 months ago

Brief Issue Summary

When a CMakePreset is added through QuickStart, or if the user escapes out before adding a preset, the usepresets context is not set, and so no preset options pop up in the command pallete.

CMake Tools Diagnostics

No response

Debug Log

No response

Additional Information

No response

v-frankwang commented 4 months ago

@qarni @gcampbell-msft This issue has been fixed, should I close it?

gcampbell-msft commented 4 months ago

@qarni @v-frankwang I don't think that it's been fixed, we'll leave it open pending confirmation from Fatima.

qarni commented 4 months ago

@qarni @v-frankwang I don't think that it's been fixed, we'll leave it open pending confirmation from Fatima.

Yeah, this hasn't been fixed.

v-frankwang commented 4 months ago

@qarni @gcampbell-msft Thank you very much for your replies, I'm very sorry I guess I didn't understand the question, here are my steps, can you give me some advice?

Steps: repro4

qarni commented 3 months ago

https://github.com/microsoft/vscode-cmake-tools/assets/17552078/00db1d00-8007-4980-ae5a-aad92ea6126b

Ashley-Li commented 2 months ago

Verified on CMake Tools v1.18.43(release), this issue was fixed: image

https://github.com/microsoft/vscode-cmake-tools/assets/56664234/6a596537-2842-478c-bb97-e9dae1fdbbf9