microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools
MIT License
1.43k stars 430 forks source link

Fixes #3140 - Test log unavailable #3752

Closed hippo91 closed 6 days ago

hippo91 commented 1 month ago

This change addresses item #3140

This changes visible behavior

The following changes are proposed:

Other Notes/Information

I did not add test yet. I'll be happy to do so but i need some help or documentation.

hippo91 commented 2 weeks ago

@gcampbell-msft i added an entry in the CHANGELOG.

I do not understand why do you mean by "give yourself recognition".

gcampbell-msft commented 1 week ago

@gcampbell-msft i added an entry in the CHANGELOG.

I do not understand why do you mean by "give yourself recognition".

There are many examples in the changelog where people give themselves credit for the fix.

Here is an example:

"Update api.ts to add the onSelectedConfigurationChanged event. #3671 @OrkunTokdemir"

hippo91 commented 1 week ago

@gcampbell-msft IMHO the CHANGELOG is good as is. No need for me to take credits of such small changes. ;-)