Configure precondition handler to return boolean to signal a successful recovery case

microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools

MIT License

1.43k stars 430 forks source link

Configure precondition handler to return boolean to signal a successful recovery case #3776

Open andreeis opened 1 month ago

andreeis commented 1 month ago

Fix for bug https://github.com/microsoft/vscode-cmake-tools/issues/3554. Making configure precondition handler return a boolean helps to differentiate the successful recovery cases so that, for example, when we manage to recover, to continue to build instead of stopping the workflow and have the user go through the build command again.

andreeis commented 1 month ago

Latest commit was done into this branch by mistake, it was meant for another bug.

gcampbell-msft commented 1 month ago

@andreeis This PR looks good, but do we need a CHANGELOG.md update?