Fix GitHub 1401, diagnostics relative to workspace folder - Githubissues

microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools

MIT License

1.43k stars 430 forks source link

Fix GitHub 1401, diagnostics relative to workspace folder #3780

Open fargies opened 1 month ago

fargies commented 1 month ago

This change addresses item #1401

This changes how relative filepath in diagnostics are resolved

The following changes are proposed:

relative diagnostics files are searched in build_dir and src_dir, first existing file is returned
defaults to old behavior : path.resolve(build_dir, file)
resolveDiagnostics has been made async to not slow down IDE when testing files

The purpose of this change

Depending on tools, compiler and CMake invocation, diagnostics paths may be relative, but either to source directory or build directory.

This is a try and guess approach, with a preference for old behavior (returning build_dir/file).

Other Notes/Information

fargies commented 1 month ago

@microsoft-github-policy-service agree company="CERN"