search

microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools
MIT License
1.46k stars 449 forks source link

implement #2521 by adding output channel argument #3785

Closed stepeos closed 2 months ago

stepeos commented 4 months ago

Hi there, this is my first ts PR, so be adivesd. I really wanted this functionality so I'll throw the ball.

This change addresses item #2521

The changes include:

an option to keep the output channel hidden unless there is a build or configuration error

The following changes are proposed:

  1. add optional boolean argument to showChannel of the logging output channel
  2. call showChannel after building/configuring so that the "on error" option can be triggered

The purpose of this change

Building and configuring a project should not divert the programmers focus from the code when building. The user actually only needs to see the output window if an error occurs.

Other Notes/Information

I see no other way than calling showChannel twice since option "always" expects the showChannel to pop before configuring starts while "on error" expects it after.

stepeos commented 4 months ago

@microsoft-github-policy-service agree

stepeos commented 2 months ago

@gcampbell-msft any update on this? It's been months and it's not being merged?

gcampbell-msft commented 2 months ago

@stepeos Thanks for the ping, we've had it on our backlog for awhile and just haven't gotten to it, thanks for the reminder.

gcampbell-msft commented 2 months ago

@stepeos Overall it looks good, but could you add a CHANGELOG update?

v-frankwang commented 1 month ago

We verified the issue on CMake tools: v1.19.45 and it has been fixed.

ENV： CMake Tools:v1.19.45 vscode: 1.92.2

Actual result: image