Dispose of Launch terminal if environment has changed - Githubissues

microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools

MIT License

1.48k stars 457 forks source link

Dispose of Launch terminal if environment has changed #3902

Closed jophippe closed 4 months ago

jophippe commented 4 months ago

This change addresses item #3478

This changes when a Launch terminal gets re-used

The following changes are proposed:

Create terminal Launch environment at the start of the function to compare it to existing terminals
Compare the entire environment of the existing terminal with the current environment and dispose of existing terminal if any changes are found, so that the old environment is not used on later runs
Remove the refreshLaunchEnvironment variable since the environment compare does the same thing, but more complete

Other Notes/Information

Open to feedback for ways to compare environments that are better than a stringify equality

gcampbell-msft commented 4 months ago

@jophippe Don't forget the CHANGELOG entry 👍