search

microsoft / vscode-cmake-tools

CMake integration in Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=vector-of-bool.cmake-tools
MIT License
1.48k stars 454 forks source link

fix regression of kit environment variables #3991

Closed gcampbell-msft closed 3 months ago

gcampbell-msft commented 3 months ago

See title.

Fixing issue where we incorrectly were merging the kit environment on top of penv before expanding. We don't support referencing the environmentVariables map.

gcampbell-msft commented 3 months ago

@moyo1997 Well, technically it's going to have some level of penv supported either way, because expandString will call it's parent environment replacer regardless, so I think we might as well have that.